Skip to content

feat: add support for major openshift version upgrade #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: add support for major openshift version upgrade #778

wants to merge 8 commits into from
+159 −16

Conversation

iamar7
Copy link
Member

@iamar7 iamar7 commented Aug 21, 2025 •
edited
Loading

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7 iamar7 marked this pull request as ready for review August 28, 2025 07:15
@iamar7
Copy link
Member Author

iamar7 commented Aug 28, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 28, 2025

/run pipeline

@iamar7 iamar7 self-assigned this Aug 28, 2025
@iamar7
Copy link
Member Author

iamar7 commented Aug 28, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 29, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 31, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 31, 2025 

TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │ Error: Plugin did not respond
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │ 
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │   with module.ocp_base.data.ibm_container_cluster_config.cluster_config[0],
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │   on ../../main.tf line 332, in data "ibm_container_cluster_config" "cluster_config":
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │  332: data "ibm_container_cluster_config" "cluster_config" {
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │ 
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │ The plugin encountered an error, and failed to respond to the
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │ plugin.(*GRPCProvider).ReadDataSource call. The plugin logs may contain
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: │ more details.
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: ╵
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: Stack trace from the terraform-provider-ibm_v1.82.0 plugin:
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: panic: runtime error: invalid memory address or nil pointer dereference
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x1ae8e24]
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: goroutine 319 [running]:
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: github.com/IBM-Cloud/bluemix-go/api/container/containerv2.(*clusters).GetClusterConfigDetail(0xc005531188, {0xc005466b88, 0x14}, {0xc005528ec0, 0x38}, 0x1, {{0x0, 0x0}, {0xc005217880, 0x20}, ...}, ...)
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 	github.com/IBM-Cloud/bluemix-go@v0.0.0-20250818082648-8ebc393b4b26/api/container/containerv2/clusters.go:363 +0x1304
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes.dataSourceIBMContainerClusterConfigRead.func2()
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes/data_source_ibm_container_cluster_config.go:226 +0x97
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry.RetryContext.func1()
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 	github.com/hashicorp/terraform-plugin-sdk/v2@v2.35.0/helper/retry/wait.go:30 +0x4e
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry.(*StateChangeConf).WaitForStateContext.func1()
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 	github.com/hashicorp/terraform-plugin-sdk/v2@v2.35.0/helper/retry/state.go:113 +0x1a3
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: created by github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry.(*StateChangeConf).WaitForStateContext in goroutine 317
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 	github.com/hashicorp/terraform-plugin-sdk/v2@v2.35.0/helper/retry/state.go:86 +0x237
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: Error: The terraform-provider-ibm_v1.82.0 plugin crashed!
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: 
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: This is always indicative of a bug within the plugin. It would be immensely
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: helpful if you could report the crash with the plugin's maintainers so that it
TestRunCustomsgExample 2025-08-31T12:08:56Z command.go:206: can be fixed. The output above should help diagnose the issue.

Aashiq-J
Aashiq-J reviewed Sep 1, 2025
View reviewed changes
modules/get-ocp-version/scripts/ibm_cloud_login.sh

attempts=1
# Expects the environment variable $IBMCLOUD_API_KEY to be set
until ibmcloud login -q --no-region || [ $attempts -ge 3 ]; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be using cli commands due to this issue.
#438

ocofaigh
ocofaigh requested changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamar7 Was this approach discussed in a deep dive? Can you show it tomorrow?

modules/get-ocp-version/version.tf
required_providers {
external = {
source = "hashicorp/external"
version = ">= 2.2.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= 2.2.3, <3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aashiq-J Aashiq-J Aashiq-J left review comments

@ocofaigh ocofaigh ocofaigh requested changes

@toddgiguere toddgiguere Awaiting requested review from toddgiguere toddgiguere is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@iamar7 iamar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamar7 @ocofaigh @Aashiq-J